Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "actions/editorconfig: disable until we can combine this with … #94260

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Revert "actions/editorconfig: disable until we can combine this with … #94260

merged 1 commit into from
Jul 30, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jul 30, 2020

…ofborg (#88608)"

This reverts commit 1ccf442.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member Author

Mic92 commented Jul 30, 2020

cc @zowoq

@Mic92
Copy link
Member Author

Mic92 commented Jul 30, 2020 •
edited
Loading

@grahamc this should work now because github actions waits for ofborg.

@ofborg ofborg bot added 6.topic: policy discussion 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 30, 2020
@Mic92 Mic92 merged commit 6f59215 into NixOS:master Jul 30, 2020
@Mic92 Mic92 deleted the ci branch July 30, 2020 21:38
@grahamc
Copy link
Member

grahamc commented Jul 31, 2020

Nice, sounds great! Maybe we should move other functionality out of ofborg and in to actions, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: policy discussion 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mic92 @grahamc