Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alacritty: 0.4.3 -> 0.5.0 #94433

Merged
merged 1 commit into from
Aug 1, 2020
Merged

alacritty: 0.4.3 -> 0.5.0 #94433

merged 1 commit into from
Aug 1, 2020

Conversation

kimat
Copy link
Contributor

@kimat kimat commented Aug 1, 2020

Motivation for this change

alacritty/alacritty@v0.4.3...v0.5.0

https://github.com/alacritty/alacritty/releases/tag/v0.5.0

https://github.com/alacritty/alacritty/blob/master/CHANGELOG.md#050

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from Br1ght0ne, Ma27, cole-h and Mic92 August 1, 2020 11:03
@Ma27 Ma27 merged commit 0f8eb0b into NixOS:master Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

@cole-h cole-h Awaiting requested review from cole-h

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kimat @Ma27