Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webkitgtk: don't use clang stdenv #96692

Merged
merged 1 commit into from
Aug 31, 2020
Merged

webkitgtk: don't use clang stdenv #96692

merged 1 commit into from
Aug 31, 2020

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Aug 30, 2020 •
edited by veprbl
Loading

Ughhhh this was terrible but it seems to now be fixed by 0.
Though it doesn't seem the issue is entirely resolved- #36947.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
webkitgtk: don't use clang stdenv
804d228 
Ughhhh this was terrible but it seems to now be fixed by [0].
Though it doesn't seem the issue is entirely resolved NixOS#36947.

[0]: NixOS#91293
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 101-500 labels Aug 30, 2020
@worldofpeace worldofpeace merged commit d436250 into NixOS:master Aug 31, 2020
@worldofpeace worldofpeace deleted the webkitgtk-gcc branch August 31, 2020 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orivej orivej orivej approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@worldofpeace @orivej