Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oauth2_proxy: 6.0.0 -> 6.1.1 #97083

Merged
merged 1 commit into from
Sep 11, 2020
Merged

oauth2_proxy: 6.0.0 -> 6.1.1 #97083

merged 1 commit into from
Sep 11, 2020

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Sep 4, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/nix/store/h1d50v23fbivd3bxipslps5w2dlcwzsh-oauth2-proxy-6.0.0 50.2M
/nix/store/7cy0d0bw49dgg22kwlk714rjpm9i9ahr-oauth2-proxy-6.1.1 51.9M

@ofborg ofborg bot requested review from yorickvP, kalbasit and knl September 4, 2020 06:30
risicle
risicle approved these changes Sep 4, 2020
View reviewed changes
Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM, linux x86_64, macos 10.14

@tomberek
Copy link
Contributor

tomberek commented Sep 6, 2020

WFM, NixOS

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/217

@AndersonTorres AndersonTorres merged commit 5f4b381 into NixOS:master Sep 11, 2020
@bbigras
Copy link
Contributor Author

bbigras commented Sep 11, 2020

thanks!

@bbigras bbigras deleted the oauth2-proxy branch September 11, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@risicle risicle risicle approved these changes

@yorickvP yorickvP yorickvP approved these changes

@tomberek tomberek tomberek approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@knl knl Awaiting requested review from knl

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bbigras @tomberek @nixos-discourse @yorickvP @risicle @AndersonTorres