-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
systemd: create options for smaller derivation #98998
Conversation
@kloenk any chance you could keep this Otherwise I'd also gladly massage this in shape :-) |
I can change that. But bigger changes have to wait a little. (School takes much time currently) |
@flokli |
I'd propose to have that line look like this:
So this shouldn't cause any breakage, and we have
No worries! |
c4968ae
to
5dac951
Compare
5dac951
to
647ff64
Compare
647ff64
to
9b5a2f0
Compare
Sorry, I missed this - this is a mass rebuild, so it'll need to target staging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with all our recent systemd decisions. But this PR makes sense to me, and I'm eager to try out homed in the one that depends on it.
@kloenk says the ofborg failure doesn't reproduce locally, so I suspect this is due to ofborg merging a broken master/staging.
rebased, hopefully this fixes ofborg-eval |
Co-Authored-By: Kirill Elagin <kirelagin@gmail.com>
11c511d
to
2e52fca
Compare
Ah good with the In any event, I'm always for exposing more flags on the nix expr level. It gives gentoo people less reason to complain about us :D. |
Motivation for this change
Base work for #98299
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)