Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildRustCrate: support cross compilation #99050

Merged
merged 2 commits into from
Sep 29, 2020
Merged

buildRustCrate: support cross compilation #99050

merged 2 commits into from
Sep 29, 2020

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

Allows buildRustCrate to be used to cross-compile Rust crates. This PR implements the changes that are needed on the nixpkgs side, but neither crate2nix nor carnix (haven't tested, but a quick look at the code makes me think it doesn't) support cross-compilation. I have a WIP patch for crate2nix to fix this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @Ericson2314 @danieldk @kolloch @andir @symphorien

@lopsided98 lopsided98 requested a review from andir as a code owner September 29, 2020 00:06
@lopsided98
Copy link
Contributor Author

See nix-community/crate2nix#152 for my crate2nix patch.

@ofborg ofborg bot added the 6.topic: rust label Sep 29, 2020
@ofborg ofborg bot requested a review from adisbladis September 29, 2020 02:22
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Sep 29, 2020
Ericson2314
Ericson2314 approved these changes Sep 29, 2020
View reviewed changes
Copy link
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Don't think there is anything controversial here.

@Ericson2314 Ericson2314 merged commit cffc0ea into NixOS:master Sep 29, 2020
@Ericson2314
Copy link
Member

Ping me in the create2nix patch too please!

@lopsided98 lopsided98 deleted the buildrustcrate-cross branch September 29, 2020 05:20
@lopsided98 lopsided98 mentioned this pull request Sep 29, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Ericson2314 approved these changes

@andir andir Awaiting requested review from andir

@adisbladis adisbladis Awaiting requested review from adisbladis

Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lopsided98 @Ericson2314