draft: hunter: init at 1.3.5 #99898
draft: hunter: init at 1.3.5 #99898
Conversation
|
Sorry for the force-push: I accidentally added some commits to this branch. |
|
I' having trouble interpreting the error grahamofborg-eval is giving me. |
|
Hi @magnetophon, I'm terribly sorry, but I don't fully understand that error either. I do think this might be tricky to get merged into nixpkgs because it also pulls in the nixpkgs-mozilla repo to get a nightly version of the Rust compiler... not sure what the conventions are around accepting something like that here. This will be solved if rabite0/hunter#89 ever gets closed, but it seems like the Hunter author might have disappeared? They don't have any GitHub activity in the past ~5 months. |
|
@callahad Thanks. Yeah, I also noticed the lack of progress on hunter. |
| , callPackage | ||
| , makeRustPlatform | ||
| , fetchFromGitHub | ||
| , IOKit ? null |
There was a problem hiding this comment.
Please use inherit in top-level to not default this to null cause this will always fail on darwin.
|
|
||
| assert stdenv.isDarwin -> IOKit != null; |
There was a problem hiding this comment.
| assert stdenv.isDarwin -> IOKit != null; |
| description = "The fastest file manager in the galaxy!"; | ||
| homepage = "https://github.com/rabite0/hunter"; | ||
| license = licenses.wtfpl; | ||
| maintainers = [ maintainers.magnetophon ]; |
There was a problem hiding this comment.
| maintainers = [ maintainers.magnetophon ]; | |
| maintainers = with maintainers; [ magnetophon ]; |
| assert stdenv.isDarwin -> IOKit != null; | ||
|
|
||
| let | ||
| date = "2020-05-22"; |
There was a problem hiding this comment.
Is the current rust version in nix now sufficient?
There was a problem hiding this comment.
Nothing changed upstream since May 25.
Shall I mark this PR as WIP until upstream doesn't need nightly anymore?
There was a problem hiding this comment.
Yes please. I don't think it is a good idea to include the overlay in nix.
fixes #83554
Thanks to @callahad for writing the derivation!
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)