Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patchelf.cc: add comment explaining calculation for DT_MIPS_RLD_MAP_REL #379

Merged
merged 1 commit into from Jun 19, 2022
Merged

patchelf.cc: add comment explaining calculation for DT_MIPS_RLD_MAP_REL #379

merged 1 commit into from Jun 19, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jun 19, 2022

This commit also includes a link to the best source I could find for
what DT_MIPS_RLD_MAP_REL is supposed to be, an exact copy-paste of the
text found there, and step-by-step algebra for deriving the formula
used by the code. Hopefully this means that this is the end of the
DT_MIPS_RLD_MAP_REL headaches.

@ghost
Copy link
Author

ghost commented Jun 19, 2022

I thought I had already submitted this as part of #365 but it looks like I did not.

If the comment is too noisy just go ahead and close this unmerged.

This commit also includes a link to the best source I could find for
what DT_MIPS_RLD_MAP_REL is supposed to be, an exact copy-paste of the
text found there, and step-by-step algebra for deriving the formula
used by the code.  Hopefully this means that this is the end of the
DT_MIPS_RLD_MAP_REL headaches.
@Mic92 Mic92 merged commit 1eeac38 into NixOS:master Jun 19, 2022
@ghost ghost deleted the pr/dt_mips_rld_map_rel-comment branch June 19, 2022 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant