Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC 0166] Nix formatting, take two #166

Merged
merged 39 commits into from
Mar 5, 2024
Merged

Commits on Nov 15, 2023

  1. 166: Nix formatting

    Create 0101-nix-formatting.md
    
    WIP
    
    Go through a large part and agree on it
    
    Co-Authored-By: @piegamesde
    
    Update 0101-nix-formatting.md
    
    Rework a lot of things
    
    Update 0101-nix-formatting.md
    
    Move around some sections
    
    Reword the detailed section
    
    Minor updates
    
    Slight header changes again
    
    Updates
    
    Update 0101-nix-formatting.md
    
    Update after today's meeting
    
    Update 0101-nix-formatting.md
    
    Further updates in the meeting
    
    Update 0101-nix-formatting.md
    
    After todays meeting
    
    Update after meeting
    
    Rename to probably the right number
    
    Only use anchor links
    
    Improvements and additions
    
    - The sub-expression rule is now reworded and its own section with
      examples and rationale
    - Line length limit is now specified as we agreed-upon in the meeting
    - The operator section is rewritten to align more with the consensus
    
    Redo and explain operator special case
    
    Also remove the special case for non-chainable operators, barely any benefit
    in Nixpkgs
    infinisil committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    49edc8b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f4f382d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    940312f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    63a2fa9 View commit details
    Browse the repository at this point in the history
  5. Minor changes

    infinisil committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    9a46629 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. Light copy editing

    rhendric authored and infinisil committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    1ef40c5 View commit details
    Browse the repository at this point in the history
  2. Fix .git-blame-ignore-revs

    YorikSar authored and infinisil committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    1da4679 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. Improve assert/with wording

    infinisil committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    0513bda View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    385a914 View commit details
    Browse the repository at this point in the history
  3. binder -> binding

    infinisil authored Nov 28, 2023
    Configuration menu
    Copy the full SHA
    9ac50f8 View commit details
    Browse the repository at this point in the history
  4. unindent inherit semicolon, reshuffle binding/inherit sections (#14)

    * unindent inherit semicolon, reshuffle binding/inherit sections
    
    * fixup! Stuff
    infinisil authored Nov 28, 2023
    Configuration menu
    Copy the full SHA
    299c16f View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. Configuration menu
    Copy the full SHA
    6a6efcd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ff2f08a View commit details
    Browse the repository at this point in the history
  3. Add editorconfig

    infinisil authored Dec 12, 2023
    Configuration menu
    Copy the full SHA
    5fd9365 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4f3b3ce View commit details
    Browse the repository at this point in the history
  5. Add @dasJ to the formatter team

    infinisil authored Dec 12, 2023
    Configuration menu
    Copy the full SHA
    b717f6e View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. Add shepherd team

    Co-authored-by: Linus Heckemann <git@sphalerite.org>
    infinisil and lheckemann authored Dec 20, 2023
    Configuration menu
    Copy the full SHA
    734deb1 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. Various improvements (#15)

    * Various improvements
    
    - Remove unnecessary **Description** headers
    - Rename **Rationale and Alternatives** to just **Alternatives**
    - Insert must/may/should more diligently
    - Add some TODOs where things are unclear
    - Remove numberings from examples when not needed
    - Minor clarity improvements and simplifications throughout
    
    * Apply suggestions from code review
    
    Co-authored-by: Ryan Hendrickson <ryan.hendrickson@alum.mit.edu>
    
    ---------
    
    Co-authored-by: Ryan Hendrickson <ryan.hendrickson@alum.mit.edu>
    infinisil and rhendric authored Jan 3, 2024
    Configuration menu
    Copy the full SHA
    ac863af View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. Configuration menu
    Copy the full SHA
    b42842d View commit details
    Browse the repository at this point in the history
  2. Minor adjustments

    infinisil committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    e94e1e3 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Configuration menu
    Copy the full SHA
    4f99905 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. Working towards finalization (#16)

    - Defined absorption and absorbable terms
    - Adapted the existing RFC text to make use of these definitions,
      resulting in simplications of the text in many cases.
    - Updated `with` section to match the implementation
    - Updated the function declaration section to match the implementation
      - Sometimes, the function body may get absorbed
      - This used to be a special case scoped to bindings only, so it got removed there
    - Updated the operators section to match the implementation
      - Specify the format of non-chainable operators (somehow those got lost in the past)
    - Reworked bindings section. It should now be clear and specific enough.
    - Minor wording fixes
    piegamesde authored Feb 6, 2024
    Configuration menu
    Copy the full SHA
    6b430d7 View commit details
    Browse the repository at this point in the history
  2. String section

    infinisil committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    8cb46fd View commit details
    Browse the repository at this point in the history
  3. Specify assert conditions

    infinisil committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    8d3cd5b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1e83c6d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2c90b30 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Fix minor typos

    dasJ committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    1e5914d View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. Configuration menu
    Copy the full SHA
    c617b9f View commit details
    Browse the repository at this point in the history
  2. Specify comments

    infinisil committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    6b2f19a View commit details
    Browse the repository at this point in the history
  3. Specify that the formatter should be as pure as possible

    With some exceptions
    infinisil committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    463a858 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Configuration menu
    Copy the full SHA
    e92f5ab View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. Update rfcs/0166-nix-formatting.md

    Co-authored-by: Doron Behar <doron.behar@gmail.com>
    infinisil and doronbehar authored Mar 4, 2024
    Configuration menu
    Copy the full SHA
    6e63b6b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dec1797 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3a91c37 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f33b211 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    aa2141a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    26b444b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    685ee9b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    aaf1613 View commit details
    Browse the repository at this point in the history