-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC 0166] Nix formatting, take two #166
Merged
Merged
+1,735
−0
Commits on Nov 15, 2023
-
Create 0101-nix-formatting.md WIP Go through a large part and agree on it Co-Authored-By: @piegamesde Update 0101-nix-formatting.md Rework a lot of things Update 0101-nix-formatting.md Move around some sections Reword the detailed section Minor updates Slight header changes again Updates Update 0101-nix-formatting.md Update after today's meeting Update 0101-nix-formatting.md Further updates in the meeting Update 0101-nix-formatting.md After todays meeting Update after meeting Rename to probably the right number Only use anchor links Improvements and additions - The sub-expression rule is now reworded and its own section with examples and rationale - Line length limit is now specified as we agreed-upon in the meeting - The operator section is rewritten to align more with the consensus Redo and explain operator special case Also remove the special case for non-chainable operators, barely any benefit in Nixpkgs
Configuration menu - View commit details
-
Copy full SHA for 49edc8b - Browse repository at this point
Copy the full SHA 49edc8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f4f382d - Browse repository at this point
Copy the full SHA f4f382dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 940312f - Browse repository at this point
Copy the full SHA 940312fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 63a2fa9 - Browse repository at this point
Copy the full SHA 63a2fa9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a46629 - Browse repository at this point
Copy the full SHA 9a46629View commit details
Commits on Nov 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1ef40c5 - Browse repository at this point
Copy the full SHA 1ef40c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1da4679 - Browse repository at this point
Copy the full SHA 1da4679View commit details
Commits on Nov 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0513bda - Browse repository at this point
Copy the full SHA 0513bdaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 385a914 - Browse repository at this point
Copy the full SHA 385a914View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ac50f8 - Browse repository at this point
Copy the full SHA 9ac50f8View commit details -
unindent inherit semicolon, reshuffle binding/inherit sections (#14)
* unindent inherit semicolon, reshuffle binding/inherit sections * fixup! Stuff
Configuration menu - View commit details
-
Copy full SHA for 299c16f - Browse repository at this point
Copy the full SHA 299c16fView commit details
Commits on Dec 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6a6efcd - Browse repository at this point
Copy the full SHA 6a6efcdView commit details -
Configuration menu - View commit details
-
Copy full SHA for ff2f08a - Browse repository at this point
Copy the full SHA ff2f08aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5fd9365 - Browse repository at this point
Copy the full SHA 5fd9365View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f3b3ce - Browse repository at this point
Copy the full SHA 4f3b3ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for b717f6e - Browse repository at this point
Copy the full SHA b717f6eView commit details
Commits on Dec 20, 2023
-
Co-authored-by: Linus Heckemann <git@sphalerite.org>
Configuration menu - View commit details
-
Copy full SHA for 734deb1 - Browse repository at this point
Copy the full SHA 734deb1View commit details
Commits on Jan 3, 2024
-
* Various improvements - Remove unnecessary **Description** headers - Rename **Rationale and Alternatives** to just **Alternatives** - Insert must/may/should more diligently - Add some TODOs where things are unclear - Remove numberings from examples when not needed - Minor clarity improvements and simplifications throughout * Apply suggestions from code review Co-authored-by: Ryan Hendrickson <ryan.hendrickson@alum.mit.edu> --------- Co-authored-by: Ryan Hendrickson <ryan.hendrickson@alum.mit.edu>
Configuration menu - View commit details
-
Copy full SHA for ac863af - Browse repository at this point
Copy the full SHA ac863afView commit details
Commits on Jan 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b42842d - Browse repository at this point
Copy the full SHA b42842dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e94e1e3 - Browse repository at this point
Copy the full SHA e94e1e3View commit details
Commits on Jan 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4f99905 - Browse repository at this point
Copy the full SHA 4f99905View commit details
Commits on Feb 6, 2024
-
Working towards finalization (#16)
- Defined absorption and absorbable terms - Adapted the existing RFC text to make use of these definitions, resulting in simplications of the text in many cases. - Updated `with` section to match the implementation - Updated the function declaration section to match the implementation - Sometimes, the function body may get absorbed - This used to be a special case scoped to bindings only, so it got removed there - Updated the operators section to match the implementation - Specify the format of non-chainable operators (somehow those got lost in the past) - Reworked bindings section. It should now be clear and specific enough. - Minor wording fixes
Configuration menu - View commit details
-
Copy full SHA for 6b430d7 - Browse repository at this point
Copy the full SHA 6b430d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8cb46fd - Browse repository at this point
Copy the full SHA 8cb46fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d3cd5b - Browse repository at this point
Copy the full SHA 8d3cd5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e83c6d - Browse repository at this point
Copy the full SHA 1e83c6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c90b30 - Browse repository at this point
Copy the full SHA 2c90b30View commit details
Commits on Feb 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1e5914d - Browse repository at this point
Copy the full SHA 1e5914dView commit details
Commits on Feb 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c617b9f - Browse repository at this point
Copy the full SHA c617b9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b2f19a - Browse repository at this point
Copy the full SHA 6b2f19aView commit details -
Specify that the formatter should be as pure as possible
With some exceptions
Configuration menu - View commit details
-
Copy full SHA for 463a858 - Browse repository at this point
Copy the full SHA 463a858View commit details
Commits on Feb 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e92f5ab - Browse repository at this point
Copy the full SHA e92f5abView commit details
Commits on Mar 4, 2024
-
Update rfcs/0166-nix-formatting.md
Co-authored-by: Doron Behar <doron.behar@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6e63b6b - Browse repository at this point
Copy the full SHA 6e63b6bView commit details -
Configuration menu - View commit details
-
Copy full SHA for dec1797 - Browse repository at this point
Copy the full SHA dec1797View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a91c37 - Browse repository at this point
Copy the full SHA 3a91c37View commit details -
Configuration menu - View commit details
-
Copy full SHA for f33b211 - Browse repository at this point
Copy the full SHA f33b211View commit details -
Configuration menu - View commit details
-
Copy full SHA for aa2141a - Browse repository at this point
Copy the full SHA aa2141aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 26b444b - Browse repository at this point
Copy the full SHA 26b444bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 685ee9b - Browse repository at this point
Copy the full SHA 685ee9bView commit details -
Configuration menu - View commit details
-
Copy full SHA for aaf1613 - Browse repository at this point
Copy the full SHA aaf1613View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.