.NET template #58
Merged
.NET template #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conform to template submission guidelines
Smaug123
commented
Jan 9, 2023
| @@ -17,3 +17,4 @@ | |||
| /.github/CODEOWNERS @garbas | |||
|
|
|||
| /full @tomberek | |||
| /dotnet @Smaug123 | |||
There was a problem hiding this comment.
(Note that since I don't have write access to the repo, this CODEOWNERS line is actually useless, but it's what was in the instructions.)
Smaug123
commented
Jan 9, 2023
| src = ./.; | ||
| projectFile = projectFile; | ||
| nugetDeps = ./nix/deps.nix; | ||
| doCheck = true; |
There was a problem hiding this comment.
I believe an upstream bug actually causes the tests not to be run, but it is documented to work and the argument is accepted, so I'm inclined to just put down what's clearly meant to be correct.
kindrowboat
suggested changes
Apr 5, 2023
| * `nix develop . --command alejandra .` to run the [Alejandra](https://github.com/kamadorueda/alejandra) Nix source formatter. | ||
| * `nix develop . --command markdown-link-check README.md` to check that this README's links are not broken. | ||
| * `nix develop . --command bash -c "find . -type f -name '*.sh' | xargs shellcheck"` to check all shell scripts in this repository. | ||
| * `nix run . --` to run the application. |
There was a problem hiding this comment.
I wonder if this should specify this as nix run . -- [ARGS] and say that the included HelloWorld application requires on argument.
|
Merging as-is due to it adding value. I removed the lock per PR 72. Sorry for the late response/merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't know if you're interested in having more templates, but this one has served me well for (not-very-serious) .NET stuff.