Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated override is not followed in gitattributes #26

Closed
Nixinova opened this issue Sep 15, 2023 · 3 comments
Closed

Generated override is not followed in gitattributes #26

Nixinova opened this issue Sep 15, 2023 · 3 comments
Labels
bug Something isn't working classification Related to classifying files fixed This issue has been fixed

Comments

@Nixinova
Copy link
Owner

Having gitattributes content such as

package-lock.json -linguist-generated

does not actually lead to the file being included in the output.

@Nixinova Nixinova added bug Something isn't working classification Related to classifying files labels Sep 15, 2023
@Nixinova
Copy link
Owner Author

This occurs because default gitignored content is ignored when the list of files is being made so there is nothing to un-filter out when parsing gitattributes.

const data = walk({ init: true, commonRoot, folderRoots: resolvedInput, folders: resolvedInput, gitignores, regexIgnores });
files = data.files;
folders = data.folders;

Nixinova added a commit that referenced this issue Mar 1, 2024
Fixes files that are by default marked vendored being removed even when explicitly marked as not vendored in gitattributes.

See #26.
@Nixinova Nixinova added the in progress This is being worked on label Mar 1, 2024
@Nixinova
Copy link
Owner Author

Nixinova commented Mar 1, 2024

Being worked on at the moment; requires quite a bit of a rewrite. Tests do not pass at this stage.

@Nixinova Nixinova added fixed This issue has been fixed and removed in progress This is being worked on labels Mar 1, 2024
@Nixinova
Copy link
Owner Author

Nixinova commented Mar 1, 2024

To be fixed in 2.7

@Nixinova Nixinova closed this as completed Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working classification Related to classifying files fixed This issue has been fixed
Projects
None yet
Development

No branches or pull requests

1 participant