Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduction tutorial #102

Merged
merged 16 commits into from
Oct 29, 2022
Merged

Introduction tutorial #102

merged 16 commits into from
Oct 29, 2022

Conversation

kdgutier
Copy link
Collaborator

@kdgutier kdgutier commented Oct 28, 2022 •
edited
Loading

This PR is not affecting any functinalities.

  • Fixed the default naming of MinTrace with ridge shrinkage.
  • Re-Runned examples with fixed MinTrace names.
  • Added Introduction.ipynb.
  • Improved sidebar titles and subtitles.

kdgutier added 15 commits October 27, 2022 22:15
@kdgutier
Added motivation images, changed imgs folder and sidebar
d25cf51
@kdgutier
Merge branch 'main' of ssh://github.com/Nixtla/hierarchicalforecast i…
ef5589c 
…nto introduction_tutorial
@kdgutier
Rerunned experiments with fixed MinTrace-shrk name
3bb6ebf
@kdgutier
Fixed PERMBU description
495da03
@kdgutier
Added levels to Probabilistic reconciliation
840fc00
@kdgutier
Fixed MinTrace column name under new ridge default parameter
af3a5b9
@kdgutier
Minor change
c1478e8
@kdgutier
Added introduction references
d8083e1
@kdgutier
Added synthetic data to introduction
c9a52f0
@kdgutier
Visualize, predict and reconcile
25bfd1e
@kdgutier
Added introduction equations
3463b70
@kdgutier
recovered description cells
792b4a7
@kdgutier
Runned and changed paragraph order
81f3c0d
@kdgutier
Introduction with explanations and example
8fa59e9
@kdgutier
Merge branch 'main' of ssh://github.com/Nixtla/hierarchicalforecast i…
9ae7579 
…nto introduction_tutorial
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@kdgutier kdgutier requested review from AzulGarza and mergenthaler and removed request for AzulGarza October 28, 2022 22:52
mergenthaler
mergenthaler reviewed Oct 29, 2022
View reviewed changes
nbs/core.ipynb Show resolved Hide resolved
nbs/core.ipynb Show resolved Hide resolved
@review-notebook-app
Copy link

review-notebook-app bot commented Oct 29, 2022 •
edited
Loading

View / edit / reply to this conversation on ReviewNB

mergenthaler commented on 2022-10-29T19:38:55Z
----------------------------------------------------------------

A more informative title might be a good idea


kdgutier commented on 2022-10-29T20:43:29Z
----------------------------------------------------------------

Titles are nested, this is the subtitle of the 'Probabilistic Reconciliation' super title.

In documentation appears as

Probabilistic Reconciliation

  • PERMBU
  • Normality
  • Bootstrap

@review-notebook-app
Copy link

review-notebook-app bot commented Oct 29, 2022 •
edited
Loading

View / edit / reply to this conversation on ReviewNB

mergenthaler commented on 2022-10-29T19:38:55Z
----------------------------------------------------------------

I know this was't changed, but it might be clearer for the reader that the aggregate functions perfmos 3 different tasks and outputs 3 different things. Maybe something like:

Using the aggregate function from HierarchicalForecast we can generate:

  • Y_df: a data frame containing all sets of time series accors different hierarchies where each top level is constructed using the sum of the bottom levels.
  • S_df: the S Matrix
  • tags : ...

kdgutier commented on 2022-10-29T20:43:46Z
----------------------------------------------------------------

Done, thanks

@review-notebook-app
Copy link

review-notebook-app bot commented Oct 29, 2022 •
edited
Loading

View / edit / reply to this conversation on ReviewNB

mergenthaler commented on 2022-10-29T19:38:56Z
----------------------------------------------------------------

You are using an ETS, not an auto arima.


kdgutier commented on 2022-10-29T20:43:59Z
----------------------------------------------------------------

Changed, thanks

@review-notebook-app
Copy link

review-notebook-app bot commented Oct 29, 2022 •
edited
Loading

View / edit / reply to this conversation on ReviewNB

mergenthaler commented on 2022-10-29T19:38:57Z
----------------------------------------------------------------

ibidem


kdgutier commented on 2022-10-29T20:44:13Z
----------------------------------------------------------------

Added the improved description

mergenthaler
mergenthaler reviewed Oct 29, 2022
View reviewed changes
nbs/examples/Introduction.ipynb Show resolved Hide resolved
nbs/examples/Introduction.ipynb Show resolved Hide resolved
nbs/examples/Introduction.ipynb Show resolved Hide resolved
@kdgutier Review Notebook App
Copy link
Collaborator Author

Titles are nested, this is the subtitle of the 'Probabilistic Reconciliation' super title.

In documentation appears as

Probabilistic Reconciliation

  • PERMBU
  • Normality
  • Bootstrap

View entire conversation on ReviewNB

@kdgutier Review Notebook App
Copy link
Collaborator Author

Done, thanks

View entire conversation on ReviewNB

@kdgutier Review Notebook App
Copy link
Collaborator Author

Changed, thanks

View entire conversation on ReviewNB

@kdgutier Review Notebook App
Copy link
Collaborator Author

Added the improved description

View entire conversation on ReviewNB

@kdgutier kdgutier merged commit 0dd69d5 into main Oct 29, 2022
@kdgutier kdgutier deleted the introduction_tutorial branch October 29, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergenthaler mergenthaler mergenthaler left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kdgutier @mergenthaler