Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Added NLinear model #900

Merged
merged 8 commits into from
Mar 1, 2024
Merged

[FEAT] Added NLinear model #900

merged 8 commits into from
Mar 1, 2024

Conversation

ggattoni
Copy link
Contributor

Since DLinear was added recently, I think it might be a good idea to also have NLinear in the library.
If you are interested and/or if I'm missing something please let me know

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CLAassistant
Copy link

CLAassistant commented Feb 25, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


ggattoni seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@AzulGarza
Copy link
Member

thank you so much @ggattoni! could you sign the CLA? thank you!🙌

@ggattoni
Copy link
Contributor Author

thank you so much @ggattoni! could you sign the CLA? thank you!🙌

Sure, it's done! Let me know if I can do anything else

@cchallu
Copy link
Contributor

cchallu commented Feb 27, 2024

Hi @ggattoni! Thanks for your contribution. The nb-sync test failed, I believe you missed installing the hooks with nbdev. Can you try running nbdev_install_hooks, modifying the new linear notebook, and pushing it again? (contributing guide: https://github.com/Nixtla/neuralforecast/blob/main/CONTRIBUTING.md)

@ggattoni
Copy link
Contributor Author

Hi @ggattoni! Thanks for your contribution. The nb-sync test failed, I believe you missed installing the hooks with nbdev. Can you try running nbdev_install_hooks, modifying the new linear notebook, and pushing it again? (contributing guide: https://github.com/Nixtla/neuralforecast/blob/main/CONTRIBUTING.md)

Whoops, I thought I had configured it correctly, now it should be fixed

@cchallu cchallu merged commit e1e4474 into Nixtla:main Mar 1, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants