-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: saving and re-using fine-tuned models #562
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Experiment ResultsExperiment 1: air-passengersDescription:
Results:
Plot:Experiment 2: air-passengersDescription:
Results:
Plot:Experiment 3: electricity-multiple-seriesDescription:
Results:
Plot:Experiment 4: electricity-multiple-seriesDescription:
Results:
Plot:Experiment 5: electricity-multiple-seriesDescription:
Results:
Plot: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very cool pr!
when using distributed frameworks, we would expect an error. should we raise a particular error in that case?
Trying to fine tune on a distributed df? |
Unsolicited comments/questions:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, pretty awesome! output_model_id
(and thus later on finetuned_model_id
) can be any user chosen string, right? I suspect users will typically want to name their models with a custom string. I think we'll have to emphasize that in the docs following this PR
Yes, if provided that one is used, otherwise we generate a random UUID. |
Adds the following:
NixtlaClient.finetune
to fine tune and save a model.NixtlaClient.finetuned_models
to list the models a user has fine tuned.NixtlaClient.delete_finetuned_model
to delete an existing model.finetuned_model_id
argument to all methods to use a saved fine tuned model to compute forecasts.