Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add plotly-resampler as plotting engine #354

Merged
merged 10 commits into from
Dec 15, 2022
Merged

Conversation

jvdd
Copy link
Contributor

@jvdd jvdd commented Dec 3, 2022

This PR adds "plotly-resampler" as option for the plotting engine of StatsForecast.plot method, see #342

Would love to hear your feedback on this!


Example use of plotly-resampler (in the ElectricityLoadForecasting.ipynb notetbook)

image

Note that plotly-resampler properties can be passed in the resampler_kwargs argument.
⬇️ illustrates how for example the number of shown samples can be changed!

StatsForecast.plot(df, engine="plotly-resampler", resampler_kwargs={"default_n_shown_samples": 3000, "show_dash": {"mode": "inline"}})

PS: also fixed a minor typo in the CONTRIBUTING.md file

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@jvdd
Copy link
Contributor Author

jvdd commented Dec 3, 2022

I have read the CLA Document and I hereby sign the CLA

@jvdd
Copy link
Contributor Author

jvdd commented Dec 3, 2022

recheck

github-actions bot added a commit that referenced this pull request Dec 3, 2022
@CLAassistant
Copy link

CLAassistant commented Dec 5, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@AzulGarza AzulGarza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jvdd! Nice integration!

I have left a comment, once it is resolved, it will be ready to merge 🚀🤗

environment.yml Show resolved Hide resolved
@jvdd jvdd requested a review from AzulGarza December 10, 2022 07:50
@jvdd
Copy link
Contributor Author

jvdd commented Dec 10, 2022

I'm not sure why the macOS - Python 3.8 CI is stuck at the Run ray step in this pull request. It looks like the same issue occurred in #358 as well.

@jvdd
Copy link
Contributor Author

jvdd commented Dec 14, 2022

Not really sure if this is related to the macOS test hanging, but GitHub is performing some maintenance on their macOS virtual environments

actions/runner-images#2247

@AzulGarza AzulGarza enabled auto-merge (squash) December 15, 2022 02:55
Copy link
Member

@AzulGarza AzulGarza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jvdd!🎉

@AzulGarza
Copy link
Member

@all-contributors please add @jvdd for code

@allcontributors
Copy link
Contributor

@FedericoGarza

I've put up a pull request to add @jvdd! 🎉

@AzulGarza AzulGarza merged commit 35234c2 into Nixtla:main Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants