-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ add plotly-resampler as plotting engine #354
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jvdd! Nice integration!
I have left a comment, once it is resolved, it will be ready to merge 🚀🤗
I'm not sure why the macOS - Python 3.8 CI is stuck at the |
Not really sure if this is related to the macOS test hanging, but GitHub is performing some maintenance on their macOS virtual environments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jvdd!🎉
@all-contributors please add @jvdd for code |
@FedericoGarza I've put up a pull request to add @jvdd! 🎉 |
This PR adds
"plotly-resampler"
as option for the plottingengine
ofStatsForecast.plot
method, see #342Would love to hear your feedback on this!
Example use of plotly-resampler (in the ElectricityLoadForecasting.ipynb notetbook)
Note that plotly-resampler properties can be passed in the
resampler_kwargs
argument.⬇️ illustrates how for example the number of shown samples can be changed!
PS: also fixed a minor typo in the CONTRIBUTING.md file