Can't use passwords with symbols

[jonas-zipprick]

nobrainers uri parsing breaks when using passwords that include signs like '/' or '@'

[nviennot]

I pushed a fix. You may use %2F or %40 in the password for such characters

[zedtux]

@nviennot shouldn't be the opposite, shouldn't Nobrainer use URI.escape on the given password?

For instance I'm deploying a RethinkDB cluster in Kubernetes. I have the password in a Secret and both the cluster and the Rails app take the password from that Secret.
Following what you did, I should change my app in order to URI.escape before passing it to Nobrainer, therefor noway for me to use environment variables.

Now if Nobrainer would apply the URI.escape on the given password (as Nobrainer builds an URL), then the password is escaped and we can use environment variables again.

What's your input about this?

[nviennot]

You can use environment variables, just URI encode the username/password.
Or we should have a better parsing logic.
I'm not entirely sure I understand the issue. Feel free to revert the commit.

[zedtux]

Given a Kubernetes Secret which holds the RethinkDB password to be used:

• by the RethinkDB cluster operator or Helm chart to initialise the database
• by the Rails application in order to authenticate against the database

On the Rails, I agree with you, it would be possible to URI encore the username/password and it would work, but then it wouldn't make it on the RethinkDB side, since it would use the given string as a password.

Second, NoBrainer is building an URL, so it make sense that it escape characters.