Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscription refactoring #3

Merged
merged 13 commits into from
Feb 16, 2021
Merged

Subscription refactoring #3

merged 13 commits into from
Feb 16, 2021

Conversation

mkatliar
Copy link

Main improvements:

  • RAII-based subscription management
  • Exception-based error handling in many places

@mkatliar
Pulling out nested classes.
11e376f
@mkatliar
Moved the Coordinate enum from the RWSClient class scope to the abb::…
d83b47b 
…rws namespace scope and made it an enum class. Passing Coordinate by value instead of by reference.
@mkatliar
Refactoring the subscription mechanism.
147540f
@mkatliar
Continue refactoring the subscription mechanism
2d4ac9e
@mkatliar
Fixed memory corruption issue
546e34c
@mkatliar
Added SubscriptionGroup and SubscriptionReceiver
467a1d6
@mkatliar
WebSocket code clean-up
cbb6655
@mkatliar
Added WebSocket class
98cb5d3
@mkatliar
Removed the custom WebSocket class
7c89d97
@mkatliar
Passing exceptions from POCOClient::makeHTTPRequest() to the caller.
74c0821
@mkatliar
Switched to exception-based error handling, removed error codes and e…
0727fae 
…xception messages from RWSResult and POCOResult.
@mkatliar
Merge branch 'master' into subscription_refactoring
59218eb
Wojcik98
Wojcik98 suggested changes Feb 15, 2021
View reviewed changes
Copy link

@Wojcik98 Wojcik98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next time please make several smaller PRs :)

src/rws_interface.cpp Outdated Show resolved Hide resolved
src/rws_interface.cpp Outdated Show resolved Hide resolved
include/abb_librws/rws_client.h Outdated Show resolved Hide resolved
src/rws_common.cpp Show resolved Hide resolved
src/rws_subscription.cpp Outdated Show resolved Hide resolved
src/rws_subscription.cpp Show resolved Hide resolved
include/abb_librws/rws_state_machine_interface.h Outdated Show resolved Hide resolved
@mkatliar mkatliar merged commit aabe6b0 into master Feb 16, 2021
@mkatliar mkatliar deleted the subscription_refactoring branch February 16, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wojcik98 Wojcik98 Wojcik98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkatliar @Wojcik98