Skip to content

Building for python 3.6 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spockNinja opened this issue Sep 18, 2018 · 2 comments · Fixed by #10
Closed

Building for python 3.6 #7

spockNinja opened this issue Sep 18, 2018 · 2 comments · Fixed by #10

Comments

@spockNinja
Copy link

This project looks awesome. We are currently using Zappa, but aren't satisfied with it's bloat or packaging behavior.

One big thing missing for us is the ability to package a python 3.6 lambda application.

I believe it would be a pretty simple addition, but want to make sure it would be a welcome PR, and that my approach would be acceptable.

The only two changes I had to make locally were:

https://github.com/NoRedInk/make-lambda-package/blob/master/make_lambda_package/deps.py#L58

and

https://github.com/NoRedInk/make-lambda-package/blob/master/make_lambda_package/archive.py#L36

The rest seemed to work just fine. So I think it would be safe to put the python version behind another cli argument that defaults to 'python2.7' and also allows 'python3.6'. That argument could then be passed to build_deps and make_archive.

If a PR with that approach would be welcome, I would be happy to whip it up. Thanks!

@ento
Copy link
Contributor

ento commented Sep 27, 2018

Thanks for reaching out! The approach sounds good to me.

--runtime might be a fitting name for the flag, though I'll leave it up to you :)

@spockNinja
Copy link
Author

Awesome! --runtime sounds perfect. I'll try to get that whipped up in short order.

fredvollmer pushed a commit to fredvollmer/make-lambda-package that referenced this issue Oct 9, 2018
@ento ento closed this as completed in #10 Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants