Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix modal focus trap when the last id changes on the fly #1146

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

tesk9
Copy link
Contributor

@tesk9 tesk9 commented Oct 28, 2022

See Slack for original context.

It seems that having the key event listener using Json.Decode.oneOf to decode events is causing the decoder to not get updated. Investigation steps:

Underlying problem is already issued against elm/json here: elm/json#15

@tesk9 tesk9 requested a review from micahhahn October 28, 2022 19:05
Copy link
Member

@micahhahn micahhahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for debugging this!

@micahhahn micahhahn merged commit c525260 into master Oct 28, 2022
@micahhahn micahhahn deleted the bat/fix-modal-focus-trap-when-changing-final-id branch October 28, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants