Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app style / layout base env #32

Merged
merged 5 commits into from
Aug 11, 2017
Merged

app style / layout base env #32

merged 5 commits into from
Aug 11, 2017

Conversation

usagi-f
Copy link
Member

@usagi-f usagi-f commented Aug 11, 2017

以下を整備しました。

  • フォント周り
  • アイコン(Icon Font)
  • 全体のレイアウト

フォント周り

#26 (comment)

こちらのイメージで使ってみた、Noto Sans CJK JPを載せてみました。

アイコン(Icon Font)

http://fontawesome.io/icons/

CDN経由で大量のアイコンが簡単に使えるのでFont-Awesomeを使ってみました。

全体のレイアウト

アイコンがFont-Awesomeで済ませられるので、Photonは撤廃。

レイアウトはGrid Layout Moduleで書き直しました。

https://triple-underscore.github.io/css-grid-ja.html
http://qiita.com/kura07/items/e633b35e33e43240d363

スクリーンショット

image

@Ihara-kenta
Copy link
Contributor

CSS grid 勉強になります 🙇

Copy link
Contributor

@Ihara-kenta Ihara-kenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

このアプリ規模ならCDNで問題ないですね!
真野ちゃん
LGTM

Copy link
Contributor

@mesh1nek0x0 mesh1nek0x0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
CSS grid知らなんだ...こんなに自在にレイアウトできるんですね...

@mesh1nek0x0
Copy link
Contributor

LGTM

@usagi-f usagi-f merged commit 39af1e7 into master Aug 11, 2017
@usagi-f usagi-f deleted the feature/app-style-base branch August 11, 2017 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants