Tb fix #209
Closed
Tb fix #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 14, 2023 13:52
…d to cpu() before passing to tb_summarywriter
…. Remove unnecessary comments.
bittremieux
reviewed
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick fix to the tb TypeError issue seen here. It seems like the
if not np.isnan(metric_value)call in this line is trying to convert some of the tensor values in metric_value (e.g. the train_loss) to numpy values. From what I can tell some of the values in metrics are floats and some are tensors so I added a short check to see if there are any tensors and if so make a copy of the variable, send to cpu, send to numpy (the last part might be wholly unnecessary).