Plan for cluster support

[crzidea]

Is there any plan for cluster support?
Redis 3.0.0 beta has been released for a month.

[haio]

👍

[asilvas]

Anyone developing this support?

[albarra]

May be we have to re-build the concept of this module.
Today is completly deprecated and still it is recommended by Redis.IO site.

The problem with "cluster support" is that redis still doesn't have it on stable versions. It's on development.

The appropiate issue will be "plan for redis sentinel", i think...

[andzdroid]

I've made a compatible wrapper over node_redis for redis clusters: https://github.com/koyoki/redis-party

[brycebaril]

@albarra -- this is not deprecated at all. Chill out -- it is maintained and we're working on updating the nature of the library to be more compatible with things like sentinel and cluster.

As mentioned in other issues, Redis Sentinel and Redis Cluster support will require removing the reconnection logic from the core of this library. There is a refactor branch where I've started that work and have been rewriting the tests in a way that doesn't also combine the tests with the connection logic.

Once that is done all connection logic (sentinel, cluster, or the existing legacy reconnection logic) will all be available as separate wrappers for this library.

[albarra]

Sorry, what i meant is that in certain situations is deprecated, since it doesn't support HA.
Of course, if you have only one instance of Redis, it's the ideal module. It works perfect! 👍 , and as you said, the module has continuous updates and support. :)
greetings!

[vivekkrbajpai]

@brycebaril 👍

[mc0]

I wrote a redis cluster implementation that is similar to Antirez's ruby version. It simply wraps this redis module but I'd like to see it included with this module if possible. The only change I had to make to redis/index.js1 was to make the raw error object get passed to the on_error method, pass that along when we emit the error, and allow RedisClient#max_attempts to be 0.

I know that @brycebaril is working on a refactor branch that removes the connection logic but I'm not entirely sure that that is required for getting cluster support. I'm sure I just missed the discussion on that but is there a summary for why?

[crzidea]

@mc0
I guess connection shuold be keeped instead of just close it on_error.

[danmaz74]

@brycebaril any updates regarding Redis cluster support? I read there was a refactoring going on, but didn't see any recent updates. Thanks!

[jadbox]

+1 for cluster support

[MetaThis]

+1

[shaharmor]

Redis cluster is out now, any chance to implement support for it now?

[thelinuxlich]

+1

[alumowa]

👍

[sebbo2002]

+1

[julien51]

+1

[genediazjr]

@mranney any comments sir?

[henryoswald]

We (sharelatex.com) would be interested in sponsoring this feature if that helps. I am not sure how much work it would be to develop, potentially a few other companies would pitch in?

[thelinuxlich]

There are already two alternative modules which support Redis 3.0 cluster and are better performant than node-redis:

https://github.com/thunks/thunk-redis
https://github.com/luin/ioredis

I'm using thunk-redis and can confirm the cluster feature is working well

[henryoswald]

Very interesting, thanks!

On Wed, Apr 29, 2015 at 12:24 PM, Alisson Cavalcante Agiani <
notifications@github.com> wrote:

There are already two alternative modules which support Redis 3.0 cluster
and are better performant than node-redis:

https://github.com/thunks/thunk-redis
https://github.com/luin/ioredis

—
Reply to this email directly or view it on GitHub
#574 (comment).

Henry Oswald
shareLaTeX.com co-founder

[simontabor]

I'd be happy to try and manage getting cluster support into node_redis. I think I've got a pretty good base at https://github.com/gosquared/redis-clustr (stable in production with many ops). If anyone has suggestions/would like to jump in then go ahead :)

[vivekkrbajpai]

👍

[blainsmith]

In order to better support this project and its new group of collaborators under a new org we are trying to clean up and close issues older than 6 months. Your issue may have been fixed since the issue was open, however, if you are still experiencing a problem please re-open this issue and we will label it accordingly.

[BridgeAR]

Reopening this as it is not resolved. @simontabor would you still be up to try getting cluster support into node_redis?

[simontabor]

Yeah. Will need to find some time - hopefully soon!

[mvtcode]

I using redis 3.2.8 and setup nodes cluster
using this module not working:

{ ReplyError: MOVED 8238 127.0.0.1:6380
at parseError (/home/tanmv/test/node_modules/redis-parser/lib/parser.js:181:12)
at parseType (/home/tanmv/test/node_modules/redis-parser/lib/parser.js:291:14)
command: 'SET',
args: [ 'test-4', 2017-02-27T07:39:07.656Z ],
code: 'MOVED' }

{ ReplyError: MOVED 8238 127.0.0.1:6380
at parseError (/home/tanmv/test/node_modules/redis-parser/lib/parser.js:181:12)
at parseType (/home/tanmv/test/node_modules/redis-parser/lib/parser.js:291:14) command: 'GET', args: [ 'test-4' ], code: 'MOVED' }

I have found the module "Redis Cluster Client" (https://www.npmjs.com/package/redis-node-cluster), because before that I have not used so I parked it.
The ruby programming language support has examples in https://github.com/antirez/redis-rb-cluster

[sam2x]

no news about this ? so if I want to use the cluster feature I need to migrate to ioredis ?

[simontabor]

my earlier comment is still 100% relevant: #574 (comment). redis-clustr is stable and actively in-use with some pretty big clusters

[sam2x]

Ho great, it's a wrapper to this lib "It tries to be as unobtrusive as possible - mimicing the behaviour of the node_redis client.". Thanks @simontabor for the feedback. Will give a try

[Somebi]

Indeed, have to move to ioredis package because of this. Didn't knew this package is not supporting clustering. It's a fail...
Why this is a recommended package?
Have to add a bold not in the read me. That this package is not supporting clusters feature. To stop confusing end users.

[thelinuxlich]

last update was almost a year ago so I think it's safe to say this library is deprecated.

[stockholmux]

@thelinuxlich nope. Not deprecated. We have updates that come from upstream (redis-parser and redis-commands) - it just doesn't show in this repo.

[Somebi]

Eventually i have migrated to ioredis and successfully integrated sharded cluster. Suggest using ioredis and this team to move to ioredis team, to help them if possible.

[naseemkullah]

As per https://redislabs.com/lp/node-js-redis/

Node_redis’ support for the Cluster API is provided by an additional shim, redis-clustr.

https://github.com/gosquared/redis-clustr

[minhna]

it's 2020, almost 6 years since this issue opened. Hopefully there will be good news.

[thelinuxlich]

6 years ago I switched to ioredis for the cluster support

[aayushmall]

Any update on Cluster support on this?

[fcheong3b]

Any update for cluster support?