Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RESTDataSource cache - Redis cluster support #1750

Closed
shinyaohira opened this issue Sep 29, 2018 · 3 comments
Closed

RESTDataSource cache - Redis cluster support #1750

shinyaohira opened this issue Sep 29, 2018 · 3 comments
Labels
⛲️ feature New addition or enhancement to existing solutions

Comments

@shinyaohira
Copy link
Contributor

I would like to use RESTDataSource in production with Redis cache cluster. apollo-server-cache-redis uses redis module, but it doesn't support cluster feature.

There is an alternative module, ioredis which supports Cluster, Sentinel and Pipelining features. I found an issue @eberhara opened for sentinel support. So maybe we should migrate to it?
@ghost ghost added the ⛲️ feature New addition or enhancement to existing solutions label Sep 29, 2018
@eberhara
Copy link
Contributor

eberhara commented Oct 4, 2018

@shinyaohira just created a PR #1770 with an implementation for that.
Would you mind to review and share your thoughts?

@eberhara eberhara mentioned this issue Oct 4, 2018
Merged
4 tasks
@shinyaohira
Copy link
Contributor Author

@eberhara Sure!

@benoitemile
Copy link

we can close this

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
⛲️ feature New addition or enhancement to existing solutions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@benoitemile @shinyaohira @jbaxleyiii @eberhara