Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(code-fetcher): improve multi-line code snippet #329

Merged
merged 1 commit into from
Dec 17, 2023

Conversation

PierreDemailly
Copy link
Member

Highlight the whole <tr> when multi-line because highlight.js span can be opened/closed on differents lines.

With theses screens code snippet example, a span is opened line 22 & closed line 27 (by highlight.js), this why the line 27 is not fully highlighted

Before

image

Now

image

@PierreDemailly PierreDemailly merged commit ef88324 into master Dec 17, 2023
9 checks passed
@PierreDemailly PierreDemailly deleted the improve-code-fetcher-v2 branch December 17, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants