Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(interface) : Allow to customize the theme for report export #380

Merged

Conversation

halcin
Copy link
Contributor

@halcin halcin commented May 11, 2024

Allow to customize the theme for report export #352

@fraxken fraxken requested a review from PierreDemailly May 11, 2024 00:23
Copy link

codecov bot commented May 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.25%. Comparing base (28ee6a9) to head (892fe58).
Report is 100 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##            master     #380       +/-   ##
============================================
- Coverage   100.00%   89.25%   -10.75%     
============================================
  Files           15       19        +4     
  Lines          649     1145      +496     
============================================
+ Hits           649     1022      +373     
- Misses           0      123      +123     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PierreDemailly
Copy link
Member

@halcin good job friend
It would be nice to have the browser value as default (instead of light)
Something like that:

const defaultTheme = window.matchMedia && window.matchMedia('(prefers-color-scheme: dark)').matches ? "dark" : "light";

Wdyt ?

@halcin
Copy link
Contributor Author

halcin commented May 11, 2024

ok I set the value of button radio with value of browser preference

@fraxken fraxken merged commit f13f1b1 into NodeSecure:master May 15, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants