This repository has been archived by the owner on Aug 14, 2024. It is now read-only.
Add memoize option to read API #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @fraxken , I renamed the option to "isMemoize" due to potential conflicts. Note that I'm creating this draft to make sure I've got it right and that testing and documentation will follow. |
|
@fabnguess no the argument must remain And please always open PR including documentation + test |
fraxken
suggested changes
Mar 16, 2023
fabnguess
force-pushed
the
memoize_option_read
branch
from
8ece226
to
7439ee8
Compare
fraxken
reviewed
Mar 16, 2023
fraxken
requested review from
antoine-coulon,
Kawacrepe,
PierreDemailly and
tony-go
fabnguess
force-pushed
the
memoize_option_read
branch
from
7439ee8
to
ba92d5a
Compare
fraxken
suggested changes
Mar 17, 2023
fabnguess
force-pushed
the
memoize_option_read
branch
from
ba92d5a
to
27777a5
Compare
fabnguess
force-pushed
the
memoize_option_read
branch
from
27777a5
to
0a40739
Compare
fraxken
approved these changes
Mar 17, 2023
PierreDemailly
approved these changes
Mar 17, 2023
fabnguess
force-pushed
the
memoize_option_read
branch
from
0a40739
to
e1b331d
Compare
antoine-coulon
approved these changes
Mar 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue https://github.com/NodeSecure/rc/issues/73
close #73