test(e2e): add nominal tests for exec & init CLI commands #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErwanRaulo
force-pushed
the
test-cli-integration
branch
from
a784008 to
9425a2f
Compare
no breaking changes use childprocess to collect CLI stdout missing limit case tests fix NodeSecure#395
ErwanRaulo
force-pushed
the
test-cli-integration
branch
from
9425a2f to
bae3766
Compare
ErwanRaulo
commented
Jan 1, 2025
| @@ -19,6 +19,7 @@ | |||
| "lint": "eslint src test bin scripts", | |||
| "test-only": "glob -c \"tsx --test-reporter=spec --test\" \"./test/**/*.spec.ts\"", | |||
| "test": "c8 --all --src ./src -r html npm run test-only", | |||
| "test:e2e": "glob -c \"tsx --test-reporter=spec --test\" \"./test/commands/*.spec.ts\"", | |||
There was a problem hiding this comment.
i think functional tests are not executed during development as we expect quick feedback from small unit tests.
| } | ||
|
|
||
| export function filterProcessStdout(options, filter): Promise<string[]> { | ||
| return new Promise((resolve, reject) => { |
There was a problem hiding this comment.
childprocess was turned into promise in order to collect filtered stdout outputs and emit them all at the end.
fraxken
reviewed
Jan 3, 2025
Comment on lines
+65
to
+76
| let actualLines: string[] = []; | ||
|
|
||
| try { | ||
| actualLines = await filterProcessStdout(options, byMessage); | ||
| } | ||
| catch (error) { | ||
| console.log(error); | ||
|
|
||
| assert.fail("Execute command should not throw"); | ||
| } | ||
|
|
||
| assert.deepEqual(actualLines, expectedLines, "we are expecting these lines"); |
There was a problem hiding this comment.
Suggested change
| let actualLines: string[] = []; | |
| try { | |
| actualLines = await filterProcessStdout(options, byMessage); | |
| } | |
| catch (error) { | |
| console.log(error); | |
| assert.fail("Execute command should not throw"); | |
| } | |
| assert.deepEqual(actualLines, expectedLines, "we are expecting these lines"); | |
| const actualLines = await filterProcessStdout(options, byMessage); | |
| assert.deepEqual(actualLines, expectedLines, "we are expecting these lines"); |
There was a problem hiding this comment.
Pas forcément besoin de rendre complexe juste pour un message de failure spécifique
Comment on lines
+18
to
+23
| const __dirname = path.dirname(fileURLToPath(import.meta.url)); | ||
| const processDir = path.join(__dirname, "..", "fixtures"); | ||
| const configFilePath = path.join(processDir, ".nodesecurerc"); | ||
|
|
||
| describe("Report init command", async() => { | ||
| beforeEach(async() => await fs.unlink(configFilePath)); |
There was a problem hiding this comment.
Il faudrait plutôt créer la configuration dans le path temp pour ne pas avoir de problèmes avec une modification non-prévu du fichier dans /fixtures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TOFIX: could run tests before TS migration, now something goes wrong with childprocess and execution path.
when running nreport init, main process throws the same error :
Error: ENOENT: no such file or directory, open 'C:<yourDevDir>\report\dist\views\template.html'
process try to access views from dist folder but it does not exists, should be added to dist folder as asset in tsconfig file to include a copy when compiling typescript