Remove without_storage_info for the staking pallet #621
Conversation
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
Codecov Report
@@ Coverage Diff @@
## master #621 +/- ##
===========================================
- Coverage 89.46% 40.53% -48.93%
===========================================
Files 40 40
Lines 6370 2716 -3654
===========================================
- Hits 5699 1101 -4598
- Misses 671 1615 +944
Continue to review full report at Codecov.
|
| "start_session:[{:#?}] - Error, Could be BondedSessions Overflow", | ||
| line!() | ||
| ); | ||
| return (); |
There was a problem hiding this comment.
Is this return needed here?
| .iter() | ||
| .take_while(|&&session_idx| session_idx < first_kept) | ||
| .count(); | ||
|
|
||
| for prune_session in bonded.drain(..n_to_prune) { | ||
| for prune_session in bonded.to_vec().drain(..n_to_prune) { |
There was a problem hiding this comment.
can't we get an iter from an bounded vec?
|
Thanks for comment, pallet-staking is low priority right now. PR is not ready for review. will take up the comment when working on it. |
|
@rajesh-nodle can you create move the rajesh-nodle:shamb0/bounded_staking to NodleCode/chain:feature/bounded_staking so we keep the changes in that branch but close this PR here? |
Part of #173
Code Re-factor on Sub-functionalities ...
Hooks Error Handling needs to be re-visited.
Existing Unit
Unit Test code extention
Status on Support Ticket raised to Parity