Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix)cargo doc workflow #741

Merged
merged 2 commits into from
May 10, 2023
Merged

(fix)cargo doc workflow #741

merged 2 commits into from
May 10, 2023

Conversation

Hounsette
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #741 (7f2cb5a) into master (1dff75e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #741   +/-   ##
=======================================
  Coverage   59.03%   59.03%           
=======================================
  Files          38       38           
  Lines        4670     4670           
=======================================
  Hits         2757     2757           
  Misses       1913     1913           

Comment on lines -16 to +11
- uses: actions-rust-lang/setup-rust-toolchain@v1
with:
toolchain: ${{ env.nightly }}
target: ${{ env.target }}
- run: rustup show
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By this are we relying on the version of the rust that is preinstalled on the ubuntu-latest machine?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more reading here.
It will be overridden by the version declared in the rust-toolchain file.

We can replace all the actions-rust-lang/setup-rust-toolchain@v1 in the workflow files by rustup show

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Hounsette. The link you have put here seems not relevant to our discussion or I couldn't find out how. Also I have noticed after the merge of this PR some builds have failed. I still don't get how rustup show can replace setting up the toolchain if it's not already setup.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was the wrong link, here is the explanation.

@Hounsette Hounsette merged commit 077b1f1 into master May 10, 2023
@Hounsette Hounsette deleted the fix/cargo_doc branch May 10, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants