-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to polkadot-v1.13.0 #875
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…takes in publishing them regularly to crates.io
It's safe enough to use the benchmark results of TechnocalCommitte for AllocationsMembers
ETeissonniere
previously approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Among the changes done for this implementation we have the StorageWeightReclaim feature which is introduced in Polkadot v1.9.0 and no issues reported about it since then. However my investigation shows the polkadot system parachains have not adopted it yet. This feature would allow the differences between benchmarked proof sizes and the actual proof sizes to be accounted for plus a facility for manual weight metering inside on_idle. This needs both the client and the runtime to support it. I noticed we had brought a part of this feature to our runtime. In this PR our client and runtime will become compatible about this check. My own assessment is this should be a pretty safe adoption especially if no problems are discovered during testing and try-runtime. The good thing about keeping it is that our upgrade will become closer to the upstream template/suggestion for parachains.
on-chain-release-build
feature for eden-runtimeon-chain-release-build
featureStorageWeightReclaim
: PoV Reclaim Runtime Side paritytech/polkadot-sdk#3002#[cfg(feature = "runtime-benchmarks")]
type XcmpQueue = (); => Result: it doesn't seem so and it's not fixing xcm benchmarking