Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to polkadot-v1.13.0 #875

Merged
merged 74 commits into from
Aug 21, 2024
Merged

Upgrade to polkadot-v1.13.0 #875

merged 74 commits into from
Aug 21, 2024

Conversation

aliXsed
Copy link
Contributor

@aliXsed aliXsed commented Aug 5, 2024

Among the changes done for this implementation we have the StorageWeightReclaim feature which is introduced in Polkadot v1.9.0 and no issues reported about it since then. However my investigation shows the polkadot system parachains have not adopted it yet. This feature would allow the differences between benchmarked proof sizes and the actual proof sizes to be accounted for plus a facility for manual weight metering inside on_idle. This needs both the client and the runtime to support it. I noticed we had brought a part of this feature to our runtime. In this PR our client and runtime will become compatible about this check. My own assessment is this should be a pretty safe adoption especially if no problems are discovered during testing and try-runtime. The good thing about keeping it is that our upgrade will become closer to the upstream template/suggestion for parachains.

  • Remove xToken
  • Update Dependencies
  • Fix XCM build while sticking to v3
  • Fix Runtime
  • Fix Node (Update jsonrpsee here)
  • Fix tests
  • Fix benchmarks
  • Fix and test try-runtime
  • Bump up all our crate versions
  • Fix on-chain-release-build feature for eden-runtime
  • Update CI to produce the runtime with on-chain-release-build feature
  • Add and enable the rest of the benchmark command
  • Bake eden-dev chainspec into runtime which is useful for benchmarking
  • Remove redundant code in chain-spec
  • Verify new frame_system::Config
  • Check if async backing is properly supported
  • Verify block duration for parachain (6s according to polkadot parachain templates or 12s as before and according to parachain-commons
  • Verify the necessity of StorageWeightReclaim: PoV Reclaim Runtime Side paritytech/polkadot-sdk#3002
  • Review XCM config
  • Check if we need to
    #[cfg(feature = "runtime-benchmarks")]
    type XcmpQueue = (); => Result: it doesn't seem so and it's not fixing xcm benchmarking
  • Fix collator-selection benchmarking
  • Fix membership benchmarking
  • Fix fungible benchmarking
  • Fix contracts benchmarking
  • Fix XCM benchmarking
  • Fix generic benchmarking
  • devcontainer CI build failing
  • Add any migration logic needed
  • Fix front-run risk in cumulus_pallet_xcmp_queue::migration::v5
  • Test XCM transfer with Zombienet
  • Do benchmark and update weights

simonsso and others added 2 commits August 14, 2024 00:48
It's safe enough to use the benchmark results of TechnocalCommitte for AllocationsMembers
ETeissonniere
ETeissonniere previously approved these changes Aug 19, 2024
@aliXsed aliXsed merged commit 6453a4a into master Aug 21, 2024
9 of 10 checks passed
@aliXsed aliXsed deleted the aliX/upgrade branch August 21, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants