Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix links in viewer #20

Closed
NoelDeMartin opened this issue Jun 5, 2024 · 1 comment
Closed

Fix links in viewer #20

NoelDeMartin opened this issue Jun 5, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@NoelDeMartin
Copy link
Owner

NoelDeMartin commented Jun 5, 2024 •
edited
Loading

Well, I just published my Ramen recipe and I realized a couple of things are not working as they should 😅. In particular:

  • When a link points to a public recipe, it should be loaded in Umai; rather than opening the link in a new tab. This should be fixed by preloading the list of public recipes when viewing a single recipe.
  • When a link points to the viewer for another recipe, the navigation is not working properly.
@NoelDeMartin NoelDeMartin added the bug Something isn't working label Jun 5, 2024
@NoelDeMartin NoelDeMartin mentioned this issue Sep 13, 2024
Open
NoelDeMartin added a commit that referenced this issue Dec 2, 2024
@NoelDeMartin
#20 Fix auto-linking in viewer
abb0a4c 
It wasn't working properly when the links where clicked before the list had been loaded.
NoelDeMartin added a commit that referenced this issue Dec 2, 2024
@NoelDeMartin
#20 Fix auto-linking query parameters
095ea2e
@NoelDeMartin
Copy link
Owner Author

Fixed in v0.1.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NoelDeMartin