fix: Don't cancel if refund fails

Nofraud · Jun 16, 2023 · 00c3f36 · 00c3f36
1 parent 92ea933
commit 00c3f36
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/Cron/OrderFraudStatus.php b/Cron/OrderFraudStatus.php
@@ -143,7 +143,14 @@ public function updateOrdersFromNoFraudApiResult($orders, $storeId)
                         }
                         if ($this->configHelper->getAutoCancel($storeId)) {
                             if (isset($decision) && ($decision == 'fail' || $decision == "fraudulent")) {
-                                $this->orderProcessor->handleAutoCancel($order, $decision);
+                                // If auto-cancel fails, then update the order status to the configured status
+                                if(!$this->orderProcessor->handleAutoCancel($order, $decision)){
+                                    if (!empty($newStatus)) {
+                                        $this->orderProcessor->updateOrderStatusFromNoFraudResult($newStatus, $order, $response);
+                                    } else {
+                                        $order->setNofraudStatus($decision);
+                                    }
+                                }
                                 continue;
                             }
                         }

diff --git a/Order/Processor.php b/Order/Processor.php
@@ -164,8 +164,11 @@ public function handleAutoCancel($order, $decision)
                 $order->setState(Order::STATE_CANCELED);
                 $order->setStatus($order->getConfig()->getStateDefaultStatus(Order::STATE_CANCELED));
                 $order->save();
+
+                return true;
             }
         }
+        return false;
     }
 
     /**