Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Extension Compatible With Dynamic Property Deprecation in PHP 8.2 #33

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Make Extension Compatible With Dynamic Property Deprecation in PHP 8.2 #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa38710
fix: Remove dynamic property to ensure PHP 8.2 compatibility
soleilcot Aug 11, 2023
00797e4
fix: Make cron jobs compatible with PHP8.2
soleilcot Aug 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Api/Request/Handler/AbstractHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ class AbstractHandler
*/
protected $logger;

/**
* @var \Magento\Framework\HTTP\Client\Curl $curl
*/
protected $_curl;

/**
* AbstractHandler constructor.
* @param \NoFraud\Connect\Logger\Logger $logger
Expand Down
4 changes: 4 additions & 0 deletions Cron/NotifyNofauad.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ class NotifyNofauad
* @var transportBuilder
*/
protected $transportBuilder;
/**
* @var orderCollectionFactory
*/
protected $orderCollectionFactory;
/**
* @var inlineTranslation
*/
Expand Down
4 changes: 4 additions & 0 deletions Cron/OrderFraudStatus.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ class OrderFraudStatus
* @var RequestHandler
*/
private $requestHandler;
/**
* @var DataHelper
*/
private $dataHelper;
/**
* @var ConfigHelper
*/
Expand Down
5 changes: 5 additions & 0 deletions Helper/Data.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,11 @@ class Data extends \Magento\Framework\App\Helper\AbstractHelper
*/
protected $logDirectory;

/**
* @var DirectoryList
*/
protected $directoryList;

/**
* Constructor
*
Expand Down