Go back to protobuf.js; implement compact movement messages #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d without this...)
…nt-messages # Conflicts: # nt-app/src/store/index.js
added 3 commits
January 6, 2024 09:52
- Represent death penalty as an enum, not three booleans - Clean up vRoomFlags component state management - Avoid mutating store before clicking apply - Separate presentation information from data
myndzi
force-pushed
the
myndzi/compact-movement-messages
branch
from
15bc599 to
8428742
Compare
SkyeOfBreeze
approved these changes
Jan 13, 2024
|
oops forgot to squash it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While previous work migrated to
protobuf-es, I later learned that it was particularly slow to decode/encode protobuf messages (at least with the message structure we are using).This PR goes back to protobuf.js and makes the necessary changes to how encoding messages and processing the decoded messages works.
In addition, it implements a new message type that represents movement data much more compactly.
The generated protobuf code and various functions (including transforming movement frames to/from the compact format) has been extracted to a new library/repository, shared by both this repository and noita-together/lobby-server.
Some bug reports from test plays have been addressed in this branch as well, in particular room flag handling (which includes the lobby seed).
Requires Noita-Together/lobby-server#1