Refactor bank potions/bags, fix issues and do proper entity inheritance #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potions and powder bags retrieved from the bank were implemented as copies of the original potion/powder_stash xml files with alterations. As a result, there were some changes that dont really make sense, as well as beta-branch changes not being applied.
Changed these to inherit from the proper vanilla definitions, overriding the LuaComponent responsible for filling them normally (so we can then fill them with proper banked materials). This also fixes some old changes that have odd effects on potions retrieved from the bank.
Potions retrieved from bank inherit from vanilla potion now:
- Visible to item radar again
- Can participate in fungal shifts
- (beta branch) fixes potion mixing not working
- won't mysteriously break after 100k frames
- Break into pieces again
Powder stashes don't have any obvious issues fixed by this, but changing them in the same way is consistent and should be more future-proof