Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for SpecFlow 3.3 #50

Merged
merged 2 commits into from
Dec 11, 2020
Merged

Support for SpecFlow 3.3 #50

merged 2 commits into from
Dec 11, 2020

Conversation

DanielVuurboom
Copy link
Contributor

Fixes #49

  • Upgrade SpecFlow to 3.3.30
  • Upgrade .net FrameWork to 4.6.1 because 4.5 is no longer supported by SpecFlow
  • Fix ScenarioInfo construction

@Noksa
Copy link
Owner

Noksa commented Aug 19, 2020

Hi.
Sorry for delay.
I'll look at this request soon.

@amvi88
Copy link

amvi88 commented Sep 7, 2020 •
edited
Loading

Hello, this PR solves some of our issues trying to upgrade SpecFlow see #1939 and #1912. Would you consider adding these changes to your repo?

@Noksa Noksa merged commit 81c5f05 into Noksa:master Dec 11, 2020
@Noksa
Copy link
Owner

Noksa commented Dec 11, 2020

@amvi88
@DanielVuurboom
Merged

@amvi88
Copy link

amvi88 commented Dec 15, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noksa Noksa Noksa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Breaking change in SpecFlow 3.3.57
3 participants
@DanielVuurboom @Noksa @amvi88