Added video download and conversion for playback in Godot #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nolkaloid
reviewed
Mar 6, 2024
src/yt_dlp.gd
Outdated
| @@ -173,6 +180,25 @@ class Download extends RefCounted: | |||
| var output: Array = [] | |||
| OS.execute(executable, PackedStringArray(options_and_arguments), output) | |||
|
|
|||
| if _convert_to_video && _video_format == Video.OGV: | |||
There was a problem hiding this comment.
Please avoid C style syntax, prefer and.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented a workflow for playing a video in Godot.
This currently downloads the video and converts it with ffmpeg to ogv, so Godot can play it back. This widly inefficient in both conversion speed and in filesize, but it's the only officially supported way of Godot right now. So as long as godotengine/godot-proposals#3286 doesn't finally offer a better support of more common codecs and containers, this seems to be the only way.
I've added an example and wrote a disclaimer for this solution.