Skip to content

Commit

Permalink
media: imon: Fix null-ptr-deref in imon_probe
Browse files Browse the repository at this point in the history
It seems that the return value of usb_ifnum_to_if() can be NULL and
needs to be checked.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Tested-by: Andrey Konovalov <andreyknvl@google.com>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
  • Loading branch information
ArvindYadavCs authored and mchehab committed Oct 27, 2017
1 parent bbae615 commit 58fd55e
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions drivers/media/rc/imon.c
Original file line number Diff line number Diff line change
Expand Up @@ -2515,6 +2515,11 @@ static int imon_probe(struct usb_interface *interface,
mutex_lock(&driver_lock);

first_if = usb_ifnum_to_if(usbdev, 0);
if (!first_if) {
ret = -ENODEV;
goto fail;
}

first_if_ctx = usb_get_intfdata(first_if);

if (ifnum == 0) {
Expand Down

0 comments on commit 58fd55e

Please sign in to comment.