Skip to content

Commit

Permalink
Revert "net: phy: marvell: avoid pause mode on SGMII-to-Copper for 88…
Browse files Browse the repository at this point in the history
…e151x"

This reverts commit 6623c0f.

The original diagnosis was incorrect: it appears that the NIC had
PHY polling mode enabled, which meant that it overwrote the PHYs
advertisement register during negotiation.

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Tested-by: Yonglong Liu <liuyonglong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Russell King authored and davem330 committed Feb 3, 2019
1 parent e7b8164 commit c14f07c
Showing 1 changed file with 0 additions and 16 deletions.
16 changes: 0 additions & 16 deletions drivers/net/phy/marvell.c
Original file line number Diff line number Diff line change
Expand Up @@ -847,7 +847,6 @@ static int m88e1510_config_init(struct phy_device *phydev)

/* SGMII-to-Copper mode initialization */
if (phydev->interface == PHY_INTERFACE_MODE_SGMII) {

/* Select page 18 */
err = marvell_set_page(phydev, 18);
if (err < 0)
Expand All @@ -870,21 +869,6 @@ static int m88e1510_config_init(struct phy_device *phydev)
err = marvell_set_page(phydev, MII_MARVELL_COPPER_PAGE);
if (err < 0)
return err;

/* There appears to be a bug in the 88e1512 when used in
* SGMII to copper mode, where the AN advertisement register
* clears the pause bits each time a negotiation occurs.
* This means we can never be truely sure what was advertised,
* so disable Pause support.
*/
linkmode_clear_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT,
phydev->supported);
linkmode_clear_bit(ETHTOOL_LINK_MODE_Pause_BIT,
phydev->supported);
linkmode_clear_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT,
phydev->advertising);
linkmode_clear_bit(ETHTOOL_LINK_MODE_Pause_BIT,
phydev->advertising);
}

return m88e1318_config_init(phydev);
Expand Down

0 comments on commit c14f07c

Please sign in to comment.