Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default optimizerSteps when using viaIR #443

Open
ZumZoom opened this issue Jun 20, 2023 · 0 comments
Open

Use default optimizerSteps when using viaIR #443

ZumZoom opened this issue Jun 20, 2023 · 0 comments

Comments

@ZumZoom
Copy link

ZumZoom commented Jun 20, 2023

Currently optimizerSteps: "u" is a recommended way to configure viaIR compilation pipeline. However it might not be necessary anymore with recent versions of solidity. The suggestion of this issue is to switch to using compiler-default optimizerSteps wherever possible and maybe even remove the recommendation of using optimizerSteps: "u" from the docs.


Edit from @fvictorio: before making this recommendation in the docs, the stack traces tests need to be run without those optimizer steps. We know that our tests fail wihout them for previous versions, but if they work fine in the latest N versions (where N is TBD), then we can change the recommendation.

This means that we need to move the optimizer steps to the per-version test config, use "u" for the ones that need it, and remove it for the ones that don't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant