Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add Anvil option to JS benchmark runner #397

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Conversation

fvictorio
Copy link
Member

Manually re-applying changes from NomicFoundation/hardhat#5150

I tried cherry-picking them, but it was causing me a lot of issues, I'm not sure why.

Copy link
Member

@Wodann Wodann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'll cede to Franco for a final review

Copy link

changeset-bot bot commented Apr 26, 2024

⚠️ No Changeset found

Latest commit: 38aa2c3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@fvictorio
Copy link
Member Author

fvictorio commented Apr 26, 2024

I don't think the @foundry-rs/hardhat-anvil part is necessary if we are starting anvil manually? I removed it in 38aa2c3 and tried it and worked fine without it. And I'd rather not use that dependency (it's a bit of ahack, and I'm not sure it's maintained).

But if I'm missing something here, feel free to revert that commit.

@fvictorio fvictorio force-pushed the edr/ci/anvil-benchmark branch from 61eccfe to 38aa2c3 Compare April 26, 2024 08:16
@fvictorio fvictorio added the no changeset needed This PR doesn't require a changeset label Apr 26, 2024
@agostbiro
Copy link
Member

@fvictorio yeah @foundry-rs/hardhat-anvil it's not needed anymore, thanks for removing!

@agostbiro agostbiro merged commit ca1e5ca into main Apr 29, 2024
32 of 33 checks passed
@Wodann Wodann added this to the EDR v0.3.6 milestone Apr 29, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no changeset needed This PR doesn't require a changeset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants