Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add cheatcode docs #478

Merged
merged 8 commits into from
May 31, 2024
Merged

docs: add cheatcode docs #478

merged 8 commits into from
May 31, 2024

Conversation

agostbiro
Copy link
Member

Add cheatcode code docs.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 29, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: ae9561e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@agostbiro agostbiro temporarily deployed to github-action-benchmark May 29, 2024 08:55 — with GitHub Actions Inactive
@agostbiro agostbiro self-assigned this May 29, 2024
@agostbiro agostbiro added the no changeset needed This PR doesn't require a changeset label May 29, 2024
@agostbiro agostbiro requested review from Wodann and fvictorio May 29, 2024 08:57
@agostbiro agostbiro mentioned this pull request May 29, 2024
Merged
@agostbiro agostbiro marked this pull request as draft May 29, 2024 16:02
Wodann
Wodann requested changes May 29, 2024
View reviewed changes
Copy link
Member

@Wodann Wodann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo that needs to be fixed. Formatting also needs to be run for the markdown before merging.

Otherwise looks good

book/src/02_development/05_cheatcodes.md Outdated Show resolved Hide resolved
@agostbiro agostbiro had a problem deploying to github-action-benchmark May 29, 2024 16:27 — with GitHub Actions Error
@agostbiro agostbiro requested a review from Wodann May 29, 2024 16:27
@agostbiro agostbiro force-pushed the docs/add-cheatcode-docs branch from e5caec1 to 2f647dc Compare May 29, 2024 16:30
@agostbiro agostbiro had a problem deploying to github-action-benchmark May 29, 2024 16:30 — with GitHub Actions Error
Wodann
Wodann approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@Wodann Wodann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The typo got mixed up in the reformatting, but is still there.

Otherwise LGTM

book/src/02_development/05_cheatcodes.md Outdated Show resolved Hide resolved
@agostbiro @Wodann
Update book/src/02_development/05_cheatcodes.md
29a5601 
Co-authored-by: Wodann <Wodann@users.noreply.github.com>
@agostbiro agostbiro temporarily deployed to github-action-benchmark May 29, 2024 16:32 — with GitHub Actions Inactive
@agostbiro agostbiro marked this pull request as ready for review May 29, 2024 16:32
@agostbiro agostbiro had a problem deploying to github-action-benchmark May 31, 2024 14:46 — with GitHub Actions Error
@agostbiro agostbiro temporarily deployed to github-action-benchmark May 31, 2024 14:47 — with GitHub Actions Inactive
@agostbiro agostbiro merged commit 13857a0 into feat/solidity-tests May 31, 2024
20 checks passed
@agostbiro agostbiro deleted the docs/add-cheatcode-docs branch May 31, 2024 14:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Wodann Wodann Wodann approved these changes

@fvictorio fvictorio fvictorio approved these changes

Assignees

@agostbiro agostbiro

Labels
no changeset needed This PR doesn't require a changeset
Projects
EDR
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agostbiro @fvictorio @Wodann