Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Optimism provider #608

Merged
merged 1 commit into from
Aug 21, 2024
Merged

feat: Optimism provider #608

merged 1 commit into from
Aug 21, 2024

Conversation

Wodann
Copy link
Member

@Wodann Wodann commented Aug 19, 2024

This PR adds all required trait implementations to be able to use Optimism's chain spec for a provider.

NOTE: To expedite exposing Optimism for testing in Hardhat, I didn't spend time on adding Optimism-specific provider tests yet.

@Wodann Wodann added the no changeset needed This PR doesn't require a changeset label Aug 19, 2024
@Wodann Wodann requested a review from agostbiro August 19, 2024 22:25
@Wodann Wodann self-assigned this Aug 19, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 19, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6e7ffc2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Wodann Wodann temporarily deployed to github-action-benchmark August 19, 2024 22:25 — with GitHub Actions Inactive
agostbiro
agostbiro approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@agostbiro agostbiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

Base automatically changed from refactor/optimism-provider to feat/multichain August 20, 2024 22:58
@Wodann Wodann force-pushed the feat/optimism-provider branch from dfd80ec to 6e7ffc2 Compare August 20, 2024 22:59
@Wodann Wodann temporarily deployed to github-action-benchmark August 20, 2024 22:59 — with GitHub Actions Inactive
@Wodann Wodann merged commit a409e55 into feat/multichain Aug 21, 2024
36 checks passed
@Wodann Wodann deleted the feat/optimism-provider branch August 21, 2024 15:49
@Wodann Wodann linked an issue Aug 30, 2024 that may be closed by this pull request
Can we query an optimism-specific receipt? #379
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@agostbiro agostbiro agostbiro approved these changes

Assignees

@Wodann Wodann

Labels
no changeset needed This PR doesn't require a changeset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can we query an optimism-specific receipt?
2 participants
@Wodann @agostbiro