Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove usages of foundry-config from foundry-common #627

Merged
merged 2 commits into from
Aug 28, 2024
Merged

refactor: remove usages of foundry-config from foundry-common #627

merged 2 commits into from
Aug 28, 2024

Conversation

agostbiro
Copy link
Member

Remove usages of foundry-config from foundry-common as we want to remove foundry-config altogether. Please see individual commits for rational.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 26, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: e5bd54f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@agostbiro agostbiro requested a review from fvictorio August 26, 2024 13:27
@agostbiro agostbiro had a problem deploying to github-action-benchmark August 26, 2024 13:27 — with GitHub Actions Error
@agostbiro agostbiro self-assigned this Aug 26, 2024
@agostbiro agostbiro added the no changeset needed This PR doesn't require a changeset label Aug 26, 2024
@agostbiro agostbiro added this to the Solidity tests, phase 2 milestone Aug 26, 2024
@agostbiro agostbiro force-pushed the refactor/remove-inline-fuzz-config branch from 1c8e893 to 6b5592e Compare August 26, 2024 13:32
Base automatically changed from refactor/remove-inline-fuzz-config to feat/solidity-tests August 26, 2024 13:32
@agostbiro
Remove EvmArgs
f93de8c 
It's used by CLI crates in Foundry, EDR doesn't need it
@agostbiro
Use chains directly from Alloy
e5bd54f 
foundry-config reexports alloy_chains::{Chain, NamedChain}, use it directly instead
@agostbiro agostbiro force-pushed the refactor/prune-foundry-common branch from 28b7c88 to e5bd54f Compare August 26, 2024 13:46
@agostbiro agostbiro had a problem deploying to github-action-benchmark August 26, 2024 13:46 — with GitHub Actions Error
@agostbiro agostbiro merged commit ea913d1 into feat/solidity-tests Aug 28, 2024
36 of 37 checks passed
@agostbiro agostbiro deleted the refactor/prune-foundry-common branch August 28, 2024 08:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Wodann Wodann Wodann approved these changes

@fvictorio fvictorio Awaiting requested review from fvictorio

Assignees

@agostbiro agostbiro

Labels
no changeset needed This PR doesn't require a changeset
Projects
EDR
Archived in project
Milestone
Solidity tests, phase 2
Development

Successfully merging this pull request may close these issues.
2 participants
@agostbiro @Wodann