Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove etherscan identifier #628

Merged
merged 1 commit into from
Aug 28, 2024
Merged

refactor: remove etherscan identifier #628

merged 1 commit into from
Aug 28, 2024

Conversation

agostbiro
Copy link
Member

Remove support for identifying unknown contracts in traces through Etherscan as it's out of scope for EDR, and it depends on the foundry-config crate which we want to remove.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 26, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 99da613

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@agostbiro agostbiro requested a review from fvictorio August 26, 2024 15:39
@agostbiro agostbiro self-assigned this Aug 26, 2024
@agostbiro agostbiro temporarily deployed to github-action-benchmark August 26, 2024 15:39 — with GitHub Actions Inactive
@agostbiro agostbiro added the no changeset needed This PR doesn't require a changeset label Aug 26, 2024
@agostbiro agostbiro added this to the Solidity tests, phase 2 milestone Aug 26, 2024
Base automatically changed from refactor/prune-foundry-common to feat/solidity-tests August 28, 2024 08:41
@agostbiro
refactor: remove etherscan identifier
99da613 
Remove support for identifying unknown contracts in traces through
Etherscan as it's out of scope for EDR, and it depends on the
`foundry-config` crate which we want to remove.
@agostbiro agostbiro force-pushed the refactor/remove-etherscan-identifier branch from 56912b9 to 99da613 Compare August 28, 2024 08:46
@agostbiro agostbiro temporarily deployed to github-action-benchmark August 28, 2024 08:47 — with GitHub Actions Inactive
@agostbiro agostbiro merged commit 0748836 into feat/solidity-tests Aug 28, 2024
17 checks passed
@agostbiro agostbiro deleted the refactor/remove-etherscan-identifier branch August 28, 2024 08:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fvictorio fvictorio fvictorio approved these changes

Assignees

@agostbiro agostbiro

Labels
no changeset needed This PR doesn't require a changeset
Projects
EDR
Archived in project
Milestone
Solidity tests, phase 2
Development

Successfully merging this pull request may close these issues.
2 participants
@agostbiro @fvictorio