Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use same code path and config for Solidity test runner integration tests #637

Merged

Conversation

agostbiro
Copy link
Member

@agostbiro agostbiro commented Aug 30, 2024

This PR achieves to goal set out in #607 to use same code path and config for Solidity test runner integration tests. It does this by

  1. Allowing only one way to construct the Rust test runner (MultiContractRunner::new).
  2. Constructing the Rust test runner with the SolidityTestRunnerConfig that previously resided in edr_napi, instead of foundry_config::Config.

foundry_config::Config has been renamed to foundry_config::IntegrationTestConfig as some fields of it are still needed to build the Rust integration tests as a Foundry project. The rest of its functionality has been removed. I kept the foundry_config crate for now to be able to track the changes.

The PR doesn't contain any non-trivial code changes, so for me the most helpful would be to review it to see if anything has been removed that shouldn't be removed.

Copy link

changeset-bot bot commented Aug 30, 2024

⚠️ No Changeset found

Latest commit: 0258c35

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@agostbiro agostbiro temporarily deployed to github-action-benchmark August 30, 2024 18:47 — with GitHub Actions Inactive
@agostbiro agostbiro temporarily deployed to github-action-benchmark August 30, 2024 18:47 — with GitHub Actions Inactive
@agostbiro agostbiro marked this pull request as draft August 30, 2024 18:47
@agostbiro agostbiro added the no changeset needed This PR doesn't require a changeset label Aug 30, 2024
@agostbiro agostbiro force-pushed the refactor/integration-tests-same-code-path branch from eafb648 to 4eab047 Compare September 3, 2024 17:20
@agostbiro agostbiro temporarily deployed to github-action-benchmark September 3, 2024 17:20 — with GitHub Actions Inactive
@agostbiro agostbiro temporarily deployed to github-action-benchmark September 3, 2024 17:20 — with GitHub Actions Inactive
@agostbiro agostbiro had a problem deploying to github-action-benchmark September 4, 2024 16:20 — with GitHub Actions Error
@agostbiro agostbiro had a problem deploying to github-action-benchmark September 4, 2024 16:20 — with GitHub Actions Error
@agostbiro agostbiro temporarily deployed to github-action-benchmark September 4, 2024 16:41 — with GitHub Actions Inactive
@agostbiro agostbiro temporarily deployed to github-action-benchmark September 4, 2024 16:42 — with GitHub Actions Inactive
@agostbiro agostbiro requested a review from fvictorio September 4, 2024 16:42
@agostbiro agostbiro self-assigned this Sep 4, 2024
@agostbiro agostbiro marked this pull request as ready for review September 4, 2024 16:43
@agostbiro agostbiro merged commit dfb8659 into feat/solidity-tests Sep 5, 2024
38 checks passed
@agostbiro agostbiro deleted the refactor/integration-tests-same-code-path branch September 5, 2024 14:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no changeset needed This PR doesn't require a changeset
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants