-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add workflow for testing Optimism every night #638
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just had a quick look at the GHA part of the PR, looks nice :)
@@ -33,11 +33,9 @@ jobs: | |||
|
|||
- name: Run test | |||
uses: actions-rs/cargo@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, https://github.com/actions-rs has been archived last year and the actions repos haven't been updated for quite a while. I think it'd be nice to replace them, but maybe best to do it in a separate PR - I could propose it some time this week if you like the idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we use this across all of our GitHub actions, it would be good to do it in a follow-up task.
I created one in our backlog: #642
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a somewhat related note, do we need actions-rs/cargo
(cargo specifically) at all? It seem to be just running cargo
and we don't seem to need any cross-compilation or other target specs in general (which could be noisy, I guess), so this might be a regular run
step, instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to what @Xanewok said. I already replaced that action with a plain run
step in some workflow some time ago. It's simpler, it's straightforward to understand what it does, and it means one external dependency less.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Off-topic for this PR though)
Co-authored-by: Piotr Galar <piotr.galar@gmail.com>
Co-authored-by: Piotr Galar <piotr.galar@gmail.com>
Thank you for the suggestions, @galargh! ❤️ |
This PR adds support for replaying Optimism on-chain blocks to the CLI app and adds a GitHub workflow for nightly replays of the latest Optimism block.
This PR contains a breaking change to the CLI:
--chain-id
was removed as it can be retrieved from the remote--chain-type
was added, replacing the meaning of-c
from--chain-id
to--chain-type
Once merged, this PR commit should be cherry-picked and applied to
main
to ensure that theon.schedule
works.