Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return empty result for empty test suite #705

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

agostbiro
Copy link
Member

Make sure we return an empty test suite result for empty test suites.

The fix changes the semantics of the TestFilter slightly, hence the need for the change to crates/edr_solidity_tests/tests/it/fork.rs, but since the TestFilter isn't exposed (it's only used in integration tests), I think this is ok.

The change in semantics is that previously we only returned results for a test suite if the test name filter also matched at least one test name in the test suite. Now we return an empty result instead if the path filter and suite name filter match, but the test name filter doesn't match.

Fixes #702

Copy link

changeset-bot bot commented Oct 21, 2024

⚠️ No Changeset found

Latest commit: be4cd10

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@agostbiro agostbiro added the no changeset needed This PR doesn't require a changeset label Oct 21, 2024
@agostbiro agostbiro temporarily deployed to github-action-benchmark October 21, 2024 18:47 — with GitHub Actions Inactive
@agostbiro agostbiro self-assigned this Oct 21, 2024
@agostbiro agostbiro temporarily deployed to github-action-benchmark October 21, 2024 18:47 — with GitHub Actions Inactive
@agostbiro agostbiro requested review from Wodann and galargh October 21, 2024 18:47
@agostbiro agostbiro temporarily deployed to github-action-benchmark October 21, 2024 19:01 — with GitHub Actions Inactive
@agostbiro agostbiro temporarily deployed to github-action-benchmark October 21, 2024 19:01 — with GitHub Actions Inactive
@agostbiro agostbiro had a problem deploying to github-action-benchmark October 21, 2024 19:01 — with GitHub Actions Failure
@agostbiro agostbiro had a problem deploying to github-action-benchmark October 22, 2024 08:25 — with GitHub Actions Failure
Copy link
Member

@galargh galargh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks - this is going to be really helpful on the hardhat side 🙇

@agostbiro agostbiro temporarily deployed to github-action-benchmark October 22, 2024 08:57 — with GitHub Actions Inactive
@agostbiro agostbiro merged commit 502d3fb into feat/solidity-tests Oct 22, 2024
41 checks passed
@agostbiro agostbiro deleted the fix/empty-result-for-empty-suite branch October 22, 2024 09:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no changeset needed This PR doesn't require a changeset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants