-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove console.log backwards compatibility tests #706
Conversation
|
34eb49a
to
04cb6c0
Compare
04cb6c0
to
7be20ca
Compare
7be20ca
to
8b56d89
Compare
8b56d89
to
d0b282c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/multichain #706 +/- ##
================================================
Coverage 53.51% 53.51%
================================================
Files 236 236
Lines 27743 27743
Branches 27743 27743
================================================
Hits 14847 14847
Misses 11977 11977
Partials 919 919 ☔ View full report in Codecov by Sentry. |
d0b282c
to
ec3c837
Compare
This was already done in Hardhat in this PR: NomicFoundation/hardhat#5764
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
feat/multichain
I ended up pushing the merge commit separately as the "squash and merge" option has previously caused negative side-effects by erasing the merge commit. As a result, git becomes confused about what the base commit of this branch is. |
This PR fixes broken test files due to the upgrade to the latest Hardhat. These files were already removed in Hardhat in this PR: NomicFoundation/hardhat#5764