Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test to validate HTTP headers #710

Merged
merged 3 commits into from
Oct 28, 2024
Merged

test: add test to validate HTTP headers #710

merged 3 commits into from
Oct 28, 2024

Conversation

Wodann
Copy link
Member

@Wodann Wodann commented Oct 24, 2024

Adds a test to validate the fix in NomicFoundation/hardhat#5846. In the process, I also bumped Hardhat to the latest version, which includes the aforementioned fix.

Bumping Hardhat's version also required the removal of some stack trace tests, which had previously already been removed in Hardhat (NomicFoundation/hardhat#5764)

@Wodann Wodann added the no changeset needed This PR doesn't require a changeset label Oct 24, 2024
@Wodann Wodann self-assigned this Oct 24, 2024
Copy link

changeset-bot bot commented Oct 24, 2024

⚠️ No Changeset found

Latest commit: f717c61

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Wodann Wodann temporarily deployed to github-action-benchmark October 25, 2024 02:25 — with GitHub Actions Inactive
@Wodann Wodann marked this pull request as ready for review October 25, 2024 02:40
@Wodann Wodann requested a review from a team October 25, 2024 02:40
Copy link
Member

@agostbiro agostbiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@Wodann Wodann added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit e995977 Oct 28, 2024
37 checks passed
@Wodann Wodann deleted the fix/703 branch October 28, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changeset needed This PR doesn't require a changeset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants